Answered

Memory leak in browser and Deezer desktop app


Userlevel 2
Recently, there is a memory leak when using the player in the browser. After closing the tab with the player, the memory returns.
OS: Debian 8.8 amd64 / 3.16.0-4-amd64 #1 SMP Debian 3.16.51-3 (2017-12-13) x86_64 GNU/Linux
Browser: Firefox Quantum 59.0.2 (64-bit)
icon

Best answer by Ana. 1 April 2018, 10:43

Hi there, we don't support Linux on the web version, so I'm unable to offer much help, maybe someone else will have some input. In the meantime, there's a topic on our ideas forum about Linux support, make sure you vote for it to be implemented and join the conversation - https://en.deezercommunity.com/ideas/321
View original

83 replies

I’d also like to add my 2 cents to this. The memory leaks happen a lot on my Arch Linux system regardless of what I use. Firefox, Vivaldi (Chromium-based), MellowPlayer (Chromium-based music streaming wrapper) and the unofficial Linux port of the desktop app. Most of the time it just uses about 2 GB of RAM, which is still way too much, other times it fills up my entire RAM even when just browsing an artist page.

Iḿ facing this problem with both Linux and Windows. It was reported 2 years ago and it is still there. It affects both Linux and Windows users. It happens with my Fedora 33 machine running Firefox 84.0.1 and also with my Windows 10 machine running the same version of firefox for windows.

@Deezer, do you have any plans to fix this, or should I stop using the service and sign up to youtube music or spotify?

Userlevel 7
Badge +8

Hey @bandithedoge @vinRocha 

The plans are to improve our player across all apps this year, so we should see an improvement of the performance of our desktop app :relaxed: please hang in there and stay tuned to our community for updates, it'll be worth it!

Happy New Year!

A long while ago, you said that the developers were on it. Now, “the plans are to improve our player across all apps this year, so we should see an improvement of the performance of our desktop app” unforuntately does not sound like a plan to address the particular problem that has been reported here and confirmed multiple times.

It rather sounds like Deezer doesn’t care about fixing this. Or cannot. Or management has set other priorities.

In the meantime, Deezer keeps crashing browsers and freezing computers.

Would it be possible to hear something concrete and convincing from Deezer apart from vague marketing-speak?

Userlevel 7
Badge +8

Hi @Richard B. Kreckel, appreciate your opinion. In all honesty, it actually sounds we're going back to basics and improve the player as a whole, from scratch, not trying to fix a patch that may not offer a solution in the long term. One of our big focuses this year is to improve reliability, and that's why I suggested you to stay tuned for further updates.

Take good care and have a great week!

Userlevel 2
Badge

Same bug. After an hour or two of HD music on FF 86.

(image from about:memory snapshot)

 

Userlevel 7
Badge +8

Performance-wise there's a long road to go @bytesnz, that makes sense.

This feedback is always important - could you please confirm you're on version 4.32?

Userlevel 2
Badge

Performance-wise there's a long road to go @bytesnz, that makes sense.

This feedback is always important - could you please confirm you're on version 4.32?


Apologies the memory stats are for the web app (FF being Firefox). Will try in Chromium and see if I have the same issue.

Userlevel 7
Badge +8

Please do @bytesnz it'll be interesting to compare Deezer's performance between browsers :thumbsup_tone2:

Userlevel 2
Badge

I tested on Chrommium 88 and it seems to be fine. I did a little more digging into the memory snapshot and found “memory-file-data/string” is “Memory used to back a File/Blob based on a string”. In the snapshot above, it would have been ~10274 ~524KB chunks of blobby memory. Haven’t figured out how to dig further or do a clean up, but was wondering if they are stayin around if you are calling createObjectURL on Blobs/Files/MediaSources without then calling revokeObjectURL on them. Also noticed https://developer.mozilla.org/en-US/docs/Web/API/URL/createObjectURL#using_object_urls_for_media_streams which might be valid for you ¯\_(ツ)_/¯

 

I know you are working on a new and improved interface, but fixing this bug would make the current one not have to be closed and refreshed every couple of hours.

 

Just did a quick test to replicate it in FF (ran in console)
 

const part = 'zzzzzzzzz ';
let big = '';

for (let i = 0;i < 52000; i++) {
big += part;
}
// Take memory snapshot (60MB)
// Try making blobs without url
for (let i = 0; i < 400; i++) {
const blob = new Blob([big], {type: 'text/plain'});
}
// Take memory snapshot (60MB)
// Make blobs with urls
let urls = [];
for (let i = 0; i < 400; i++) {
const blob = new Blob([big], {type: 'text/plain'});
urls.push(URL.createObjectURL(blob));
}
// Take memory snapshot (260MB)
// Clear URLs
urls.forEach((url) => URL.revokeObjectURL(url))
// Take memory snapshot (60MB)

 

Userlevel 7
Badge +8

Very specific language here @bytesnz :sweat_smile: I've forwarded to our devs, super useful!

Keep me posted!

Userlevel 7
Badge +8

Hey @bytesnz 

Our devs got back to me on this, they say huge thanks to you for reporting it! :heart_eyes:

They've been working on the leak for quite some time now, there are a couple of solutions in mind, hopefully that can be implemented during the first half of this year.

Great work, please be in touch, I'll get your comments across to them :relaxed:

 

New user here.

Is this normal? Last night it even reached 800-900 MB.

Userlevel 7
Badge +8

Hey @pitone176 

Thanks for reaching out about this.

We've got some major updates planned for the desktop app this year and we strongly believe these will sort the RAM issue.

In the meantime, please uninstall the app, remove any Deezer folder you find in %appdata and restart your PC.

After the restart, try installing the app but not from the store:

https://www.deezer.com/desktop/download?platform=win32&architecture=x86

5GB leak in about:memory in firefox on linux as well. I wonder what will stop first the leak or my trial..

Userlevel 7
Badge +8

Hopefully the leak @David Ghitulescu!

We're very close to releasing major updates to our desktop app which should drastically improve the performance of the app! Stay tuned for more updates :relaxed:

Hi Rudi, you keep talking about the desktop app, but this thread is about the leak observed in the web application (on Linux/Windows & Firefox/Chrome). Are the updates are planned for the web app ?

 

That’s great news to know this problem will be solved soon ! Thanks !

 

-- Another french user that needs to reboot its PC because of deezer leaks :( 

Userlevel 7
Badge +8

You're right! The short answer is yes, but that's subject to other obstacles - the app is based on the web platform but the way they work is slightly different. The desktop app offering will be a bit more compact and reliable because of the way it's packaged and the updates which will be very welcomed @Raphael C42 

Fingers crossed everything will work as planned, and about the web app, development will continue to make it better :thumbsup_tone2:

In the meantime, have a good week and thank you for your support!

Adding myself to the (un)happy queue. Yep, memory leak happened to me as well on latest Firefox/Linux Mint.

Oddly it didn’t happen few weeks ago on Chromium (not Chrome) though.

Tomorrow I’ll revert on Chromium just for the sake of testing.

Still, it’s a bit of a shame that using a website (“web app” is just a silly synonym of) crumbles your PC :-/… this isn’t a *bug*, it’s poor design.

And yes, if you’re unaware of, we’re in 2021.

A small addendum: I think we’re way further from “Optimized for Internet Explorer [1024x768 resolution]” crap that stormed the Internet just “a while ago”. So answer like “we do not support Linux Browser” are not tolerable at all.

It would pleasable to read “yes, we’ve got a problem on the topic: we’re looking forward to resolve it.”… that’s to be said: “looking forward” is differently measured if it’s an open source or a paied service ;-)

Userlevel 7
Badge +8

Thanks for the feedback @Alessandro Massignan 

For Linux, we're working on an Electron app to facilitate the Deezer experience for more users. Stay tuned for updates! :relaxed:

Userlevel 1
Badge +1

Thanks for the feedback @Alessandro Massignan 

For Linux, we're working on an Electron app to facilitate the Deezer experience for more users. Stay tuned for updates! :relaxed:

No! If you’ll develop Electron App for Linux, you’ll use it on Windows too :( Electron framework is slow piece of shit eating for all resources. I hopped for UWP/PWA…

You changed me to the blue mood.

Userlevel 7
Badge +8

Hi @jirikovoego 

At the moment we're unable to develop a different type of app. But we'll keep holding on for different take in the future!

Thank you for your support :relaxed:

I also report the bug. it doesn't make sense, after a few hours Deezer can easily be consuming 6GB of RAM, I'm using the HI-FI plan. For the desktop version in windows, with the music already downloaded it consumes 50Mb of network even 100Mb constantly, which does not make sense either.

Userlevel 7
Badge +8

We totally understand and it's one of our aims to get this much better in the future @Nico S. thanks for the feedback!

In the meantime, our updated app should also improve the RAM usage, so stay tuned :relaxed:

Reply